| Age | Commit message (Collapse) | Author |
|---|
|
First, using --revision-range with 0 wouldn't work, as the path given
wouldn't have existed in revision 0. The repository path is now assumed
if using revision 0, in order to get a diff of all the files.
Second, sometimes an svn diff would have excess tabs in the diff file headers,
which we wouldn't catch correctly. We now make sure to only split the headers
into two groups, regardless of the number of tabs.
Patch by Nathan Heijermans.
Reviewed at http://reviews.reviewboard.org/r/1429/
|
|
The new default changeset support was failing to set a default changeset
description on newer versions of P4, which we would later need to parse
in order to get the file listing. We now go through the same code path we went
through with older versions of P4 in order to generate a default description
in order to get those generated files.
Patch by Laurent Nicolas.
Reviewed at http://reviews.reviewboard.org/r/1418/
|
|
The ClearCase code was calling a command and expecting the result split
across two variables, but didn't pass split_lines=True. Now it does!
Patch by Bryan Halter
Fixes bug #1423
|
|
|
|
We filtered out the username from a path when running 'hg svn info', but
not when reading from .hgrc. We now apply the same filtering logic. This
allows post-review to match a repository path with a username in it against
a repository path on a Review Board server.
Patch by Tom Saeger.
Reviewed at http://reviews.reviewboard.org/r/1390/
|
|
This change allows --diff-filename to be used with --repository-url. This
can be used to submit a diff outside of a working checkout.
Patch by Luke Robison.
Reviewed at http://reviews.reviewboard.org/r/1393/
|
|
post-review makes an assumption that the 'master' branch in a Git repository
represents SVN's 'trunk' when using git-svn. Now it uses the calculated
parent branch, which may be 'master' or may be some other branch, depending
on the repository setup.
Patch by Mike Crute
Reviewed at http://reviews.reviewboard.org/r/1307/
|
|
This implements support for --guess-description and --guess-summary with
revision ranges in Mercurial. The commit messages are concatenated to form
the description, and the first line of the first commit message forms the
summary.
Patch by Stefan Ring
Reviewed at http://reviews.reviewboard.org/r/1333/
|
|
Some Perforce setups have DNS aliases for a Perforce server. We currently
fetch the server aliases, but weren't doing anything with them. Now we support
scanning a list of aliases against the known list of repositories on Review
Board in order to find the right repository URL to use. This happens
automatically without any additional configuration.
Patch by Ravi Kondamuru
Reviewed at http://reviews.reviewboard.org/r/1235/
|
|
A recent patch introduced a refernece to HttpDigestAuthHandler, but this
should have been HTTPDigestAuthHandler.
Patch by Jason Felice
Reviewed at http://reviews.reviewboard.org/r/1290/
|
|
Patch from Ryan Oblak to add support for HTTP Digest Authentication to
post-review. It was really trivial given the work already added in for HTTP
Basic Authentication.
Testing done: This has been tested on my Review Board 1.1 alpha 1 installation
with Digest, Basic, and no authentication.
Reviewed at http://reviews.reviewboard.org/r/1265/
|
|
When adding/changing binary files against a git-svn repository, the binary
files would be filtered out of the diff. We now represent binary files
properly by faking the information in a diff.
Patch by Anthony Cruz.
Reviewed at http://reviews.reviewboard.org/r/1194/
|
|
This adds improved logic for determining the parent branch used when generating
a diff. It will attempt to detect the merge base of the current head, falling
back to defaults if necessary. A tracking branch can be manually specified
too.
The new code attempts the following:
1) Tries to detect the tracking branch for the current HEAD, if possible.
2) If a tracking branch doesn't exist, or is not remote, it will fall back
on 'origin/master'.
3) If the --tracking-branch parameter is specified, this branch will be used
instead of 'origin/master'.
It also provides unit tests for post-review. Right now, these test only
GitClient (in pure Git mode), but new tests can be added down the line for
the rest of post-review.
Patch by Dan Savilonis
Reviewed at http://reviews.reviewboard.org/r/1144/
|
|
Patch from Flavio Castelli. With this patch post-review will support the
revision-range option following the syntax explained at
http://www.review-board.org/docs/manual/dev/users/tools/post-review/#posting-committed-code
Testing done:
I have tested this new feature locally and it works fine.
I have successfully tested the following commands:
post-review --revision-range=rev1:rev2 --guess-summary --guess-description
post-review --revision-range=rev1:rev2 --guess-description
post-review --revision-range=rev1:rev2
post-review --revision-range=rev --guess-summary --guess-description
post-review --revision-range=rev
Reviewed at http://reviews.review-board.org/r/1049/
|
|
This change introduces Repository UUID support to git-svn, allowing
Review Board to match repositories by UUID instead of comparing the
repository name directly.
Patch by Matthew Woehlke.
Reviewed at http://reviews.review-board.org/r/1030/
|
|
improperly check for the os.uname function.
Fixes bug #1280.
|
|
spaces.
Fixes bug #840.
Reviewed at http://reviews.review-board.org/r/815/
|
|
|
|
file path using a "/" instead of "\" on Windows.
This fixes bug #939.
|
|
post-review with invalid cookies.
Fixes bug #808.
Reviewed at http://reviews.review-board.org/r/813/
|
|
|
|
when using post-review.
Reviewed at http://reviews.review-board.org/r/787/
Fixes bug #585
|
|
Since the dawn of time, post-review has lived in the Review Board tree, despite being a client script and not necessarily being needed on the server.
This moves post-review into a new rbtools package, which users will be able to easy_install (easy_install -U RBTools). The simplejson dependency will be fetched, and users won't have to go hunting in SVN for a script.
Over time, I'd like to add new scripts into here (such as one to apply a diff from a review request), and further down the road I'd like to create an "rbapi" (or something) package that contains a Python API for talking to a Review Board server, which rbtools (and post-review) will then use. For now, the goal is to just get post-review moved over.
Reviewed at http://reviews.review-board.org/r/788/
|
